Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hasdbxref #274

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix hasdbxref #274

wants to merge 5 commits into from

Conversation

Robbie1977
Copy link
Contributor

Still some issues from curation loading into KB. Hopefully, this closes all the issues.

@Robbie1977
Copy link
Contributor Author

FYI I've manually fixed the latest curation xrefs added over the last month.

Copy link
Member

@dosumis dosumis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one might go round forever. The problem is down to whether this has a label in input ontologies (=> de facto standard label => database_cross_reference as edge name) or not (=> hasDbXref as edge name). I think we've gone back and forth on a solution. Do avoid churn, it might be best to ensure that this label is injected via VFB_ext.owl and that we have a test in place to stop any variants on this creeping in.

@Clare72
Copy link
Contributor

Clare72 commented Feb 2, 2023

label is already in vfbext:


    <owl:AnnotationProperty rdf:about="http://www.geneontology.org/formats/oboInOwl#hasDbXref">
        <rdfs:label>database_cross_reference</rdfs:label>
    </owl:AnnotationProperty>

@dosumis
Copy link
Member

dosumis commented Feb 2, 2023

label is already in vfbext

OK. Should all be good then. Not sure why the test is failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants