Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test run column #3

Merged
merged 57 commits into from
Sep 29, 2024
Merged

Add test run column #3

merged 57 commits into from
Sep 29, 2024

Conversation

Vipitis
Copy link
Owner

@Vipitis Vipitis commented Jul 21, 2024

Adds a column for the annotate.py script for --columns "test" to indicate if shaders even run with wgpu-shadertoy.

there are some major issues:

  • this implementation relies on naga for prevalidation no longer needed
  • it is really slow
  • the currently annotated timeout column is likely filled with false positives -> use 10 seconds, retest with an ID list to be sure.
  • this only works for single pass shaders with no inputs
  • the code is messy
  • unrelated experiment code is in this branch
  • massively leaks tempfiles, the cleanup on delete is only available in python 3.12???

some of the solutions going forward

  • wgpu-core 22 lands in wgpu-native, wgpu-py and wgpu-shadertoy so we can access compilation info update to wgpu-native 22.1 pygfx/wgpu-py#547 works with v0.18.1 but does not include compilation into. Some issues are also not caught in the shader_module creation step... plenty of issue can cause a panic:
  • some solution with thread, multiprocessing, signal that works cross platform and from within iPhython to speed the sandbox up (currently writing a script for a subprocess)
  • async/parallel
  • reusing _global_device since the enumerate device call takes like 3 seconds
  • cleanup

@Vipitis Vipitis added this to the data lock milestone Jul 23, 2024
@Vipitis Vipitis marked this pull request as ready for review September 29, 2024 20:55
@Vipitis Vipitis merged commit ae78675 into main Sep 29, 2024
@Vipitis Vipitis deleted the dev-testing branch September 29, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant