Fixes discount property for SalesInvoice which should be nullable

VincentVrijburg · Nov 28, 2023 · fe31dc3 · fe31dc3
1 parent 1a0ef6a
commit fe31dc3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Moneybird.Net/Entities/SalesInvoices/SalesInvoice.cs b/src/Moneybird.Net/Entities/SalesInvoices/SalesInvoice.cs
@@ -73,7 +73,7 @@ public class SalesInvoice : IMoneybirdEntity
 
         [JsonPropertyName("discount")]
         [JsonNumberHandling(JsonNumberHandling.AllowReadingFromString)]
-        public double Discount { get; set; }
+        public double? Discount { get; set; }
 
         [JsonPropertyName("original_sales_invoice_id")]
         public string OriginalSalesInvoiceId { get; set; }

diff --git a/tests/Moneybird.Net.Tests/Responses/Endpoints/SalesInvoices/getSalesInvoices.json b/tests/Moneybird.Net.Tests/Responses/Endpoints/SalesInvoices/getSalesInvoices.json
@@ -434,7 +434,7 @@
     "reference": "Project X",
     "language": "nl",
     "currency": "EUR",
-    "discount": "0.0",
+    "discount": null,
     "original_sales_invoice_id": null,
     "paused": false,
     "paid_at": null,