Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change some value to fix installer failing for some people (free space error with extents stuff) #421

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fluoriteByte
Copy link

a very simple value change that fixed two people on the discord's free space errors when installing into an SSD,
solution discovered by coarel on discord, props to her
untested on my system but they both had their errors fixed

@fluoriteByte
Copy link
Author

potentially fixes Vanilla-OS/Albius#73
also i just remembered how to name the commits ima change it

@Coare1
Copy link

Coare1 commented Aug 19, 2024

hi, coarel here, this probably shouldn't be merged because its a very janky fix but at least we know where the issue is. i don't have time to look into it today but maybe a better fix would be double checking the amount of space left on the drive after the operation to make sure it's the correct amount?

@axtloss
Copy link
Member

axtloss commented Aug 19, 2024

that wouldn't fix anything, the installation will still fail because of insufficient space, just that it's not lvm failing but albius.
fluoritebytes solution completely gets rid of the error

@Coare1
Copy link

Coare1 commented Aug 19, 2024

true, i guess we can't exactly check if theres enough space now that i'm looking at the code, that would have to be hardcoded into albius. is there not an issue with making the volumes not take up the full amount of space within the partition? that's the main thing i'm concerned about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants