Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schedule): support days without any shows #381

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

ashhhleyyy
Copy link
Member

Previously, these would crash with "PANIC: runtime error: index out of range [-1]", which is not good.

Previously, these would crash with "PANIC: runtime error: index out of range [-1]", which is not good.
Copy link
Member

@markspolakovs markspolakovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'm a little surprised we haven't seen this in the wild (we must have had days with no shows), is this some odd edge case?

@ashhhleyyy
Copy link
Member Author

the broken code was only deployed in the last few weeks, this section was part of the schedule rework

@ashhhleyyy ashhhleyyy merged commit 7cc5bbe into development Sep 22, 2024
2 checks passed
@ashhhleyyy ashhhleyyy deleted the ash/fix-schedule branch September 22, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants