Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #944 by scaling control width independently from height #982

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

benwbrum
Copy link
Contributor

@benwbrum benwbrum commented Apr 3, 2024

Description of what you did:

This fixes problems displaying manifests that do not contain ranges in viewers sized below 180px high.

Closes #944

Copy link

codesandbox bot commented Apr 3, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented Apr 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
universalviewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2024 7:54pm

Copy link

codesandbox-ci bot commented Apr 3, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@demiankatz
Copy link
Contributor

Thanks, @benwbrum! This seems to be an improvement overall, but a couple of comments:

1.) If there is a thumbnail image for the audio, that seems to get scaled up as well, which may not be desirable. See manifest https://digital.library.villanova.edu/Item/vudl:283833/Manifest as an example of this. (That's an ugly thumbnail that looks bad no matter what you do, but this seems to make it even worse... not sure if there's a solution).

2.) I notice that you've targeted this branch against main; I wonder if it would be better to target against dev. Hopefully one of the things we can talk about at today's Community Call is branching and releasing conventions, so we can be more consistent in how we do things. I like to compare PR previews against https://www.universalviewer.dev to check for inconsistencies, and I'm seeing a lot of differences here which I believe are related to the dev branch being ahead of the main branch.

@demiankatz
Copy link
Contributor

@benwbrum, just checking in to see if you saw my review above. Please let me know if you need help moving this work forward!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UV controls scale improperly for audio manifests without ranges
2 participants