Add mechanism for entering custom configurations in examples view. #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks, @demiankatz. I hope I didn't complicate your work more. |
Not at all -- you just helped to inspire me to try to address a long-standing need. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought it would be useful to have a mechanism for providing custom configurations to the UV examples page in order to test configurable features (e.g. this came up because of a discussion about how to test #1061).
This PR adds a form element that can be used to input custom JSON configurations.
Unfortunately, it's not exactly working the way I want it to, which I think is a side effect of the way configuration merging behaves. If I add new settings, I see them getting merged into the configuration. However, if I try to change a default
truesetting tofalse, myfalsesetting is simply ignored. I don't know enough about UV configs to understand how to fix/work around this problem.I'm setting this to a draft until a solution can be found.