custom workspace example #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmauch
requested changes
Nov 8, 2023
ur_documentation/docs/source/examples/my_robot_cell/assemble_urdf.rst
Outdated
Show resolved
Hide resolved
ur_documentation/docs/source/examples/my_robot_cell/assemble_urdf.rst
Outdated
Show resolved
Hide resolved
ur_documentation/docs/source/examples/my_robot_cell/assemble_urdf.rst
Outdated
Show resolved
Hide resolved
ur_documentation/docs/source/examples/my_robot_cell/assemble_urdf.rst
Outdated
Show resolved
Hide resolved
| :alt: Planning Groups | ||
|
|
||
|
|
||
| Since we've already determined which ROS 2 controllers we want to use to start the ``ur_robot_driver``, we don't need the Setup Assistant to generate a ros2_control.yaml file. Therefore, we can skip **Step 9: ROS 2 Controllers** and **Step 10: MoveIt Controllers** for now. |
There was a problem hiding this comment.
But the files are generated nonetheless. I think we should avoid this.
ur_documentation/docs/source/examples/my_robot_cell/build_moveit_config.rst
Outdated
Show resolved
Hide resolved
ur_documentation/docs/source/examples/my_robot_cell/start_ur_driver.rst
Outdated
Show resolved
Hide resolved
ur_documentation/docs/source/examples/my_robot_cell/start_ur_driver.rst
Outdated
Show resolved
Hide resolved
fmauch
reviewed
Nov 9, 2023
my_robot_cell/my_robot_cell_description/urdf/my_robot_cell.urdf.xacro
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I think that is not what I meant to do with that file... I meant actually linking the joint_limits file from the description package, not copying its content.
fmauch
force-pushed
the
new_example_ros2
branch
from
d0fae59
to
01dd717
Compare
fmauch
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
We should think about actually restructuring this a bit, but apart from that I am rather happy with it now. Needs UniversalRobots/Universal_Robots_ROS2_Driver#977 before merging
fmauch
force-pushed
the
new_example_ros2
branch
from
150a9e8
to
f1757b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.