Skip to content

Commit

Permalink
Add note about TEM (#1136)
Browse files Browse the repository at this point in the history
---------

Co-authored-by: G.A. vd. Hoorn <[email protected]>
  • Loading branch information
fmauch and gavanderhoorn authored Oct 10, 2024
1 parent 2d026bc commit 988b151
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 1 deletion.
2 changes: 1 addition & 1 deletion ur_moveit_config/config/moveit_controllers.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ trajectory_execution:
allowed_execution_duration_scaling: 1.2
allowed_goal_duration_margin: 0.5
allowed_start_tolerance: 0.01
execution_duration_monitoring: false # Not much use when using the scaled JTC
execution_duration_monitoring: false # May lead to unexpectedly aborted goals with scaled JTC

moveit_simple_controller_manager:
controller_names:
Expand Down
18 changes: 18 additions & 0 deletions ur_moveit_config/doc/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,21 @@ interaction using
Now you should be able to use the MoveIt Plugin in rviz2 to plan and execute trajectories with the
robot as explained `here <https://moveit.picknik.ai/main/doc/tutorials/quickstart_in_rviz/quickstart_in_rviz_tutorial.html>`_.

.. note::
The MoveIt configuration provided here has Trajectory Execution Monitoring (TEM) *disabled*, as the
Scaled Joint Trajectory Controller may cause trajectories to be executed at a lower velocity
than they were originally planned by MoveIt. MoveIt's TEM however is not aware of this
deliberate slow-down due to scaling and will in most cases unnecessarily (and unexpectedly)
abort goals.

Until this incompatibility is resolved, the default value for ``execution_duration_monitoring``
is set to ``false``. Users who wish to temporarily (re)enable TEM at runtime (for use with
other, non-scaling controllers) can do so using the ROS 2 parameter services supported by
MoveIt.

.. literalinclude:: ../config/moveit_controllers.yaml
:language: yaml
:start-at: trajectory_execution:
:end-at: execution_duration_monitoring
:caption: moveit_controllers.yaml
12 changes: 12 additions & 0 deletions ur_robot_driver/doc/usage/move.rst
Original file line number Diff line number Diff line change
Expand Up @@ -67,4 +67,16 @@ To test the driver with the example MoveIt-setup, first start the driver as desc
Now you should be able to use the MoveIt Plugin in rviz2 to plan and execute trajectories with the
robot as explained `here <https://moveit.picknik.ai/main/doc/tutorials/quickstart_in_rviz/quickstart_in_rviz_tutorial.html>`_.

.. note::
The MoveIt configuration provided here has Trajectory Execution Monitoring (TEM) *disabled*, as the
Scaled Joint Trajectory Controller may cause trajectories to be executed at a lower velocity
than they were originally planned by MoveIt. MoveIt's TEM however is not aware of this
deliberate slow-down due to scaling and will in most cases unnecessarily (and unexpectedly)
abort goals.

Until this incompatibility is resolved, the default value for ``execution_duration_monitoring``
is set to ``false``. Users who wish to temporarily (re)enable TEM at runtime (for use with
other, non-scaling controllers) can do so using the ROS 2 parameter services supported by
MoveIt.

For more details, please see :ref:`ur_moveit_config`.

0 comments on commit 988b151

Please sign in to comment.