Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.3.4 #180

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Release 1.3.4 #180

merged 2 commits into from
Sep 25, 2023

Conversation

fmauch
Copy link
Collaborator

@fmauch fmauch commented Sep 18, 2023

Release PR for next release.

@fmauch fmauch added this to the Release 1.3.4 milestone Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@fmauch fmauch marked this pull request as ready for review September 22, 2023 09:52
@fmauch
Copy link
Collaborator Author

fmauch commented Sep 22, 2023

Before actually bloom-releasing this we should update the drivers to use the timeout instead of the keepalive count as this raises an error in startup.

Thinking about this: Shouldn't we make the deprecation notice a warning?

Copy link
Collaborator

@urmahp urmahp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and I also think we should make the deprecation notice a warning as mentioned in the other PR.

@fmauch fmauch marked this pull request as ready for review September 22, 2023 12:44
@fmauch fmauch requested a review from urmahp September 22, 2023 12:44
@fmauch
Copy link
Collaborator Author

fmauch commented Sep 22, 2023

Now including #182

@fmauch
Copy link
Collaborator Author

fmauch commented Sep 25, 2023

Waiting for #183. Sorry I didn't realize the warning was in two places...

@fmauch fmauch merged commit d150af4 into UniversalRobots:master Sep 25, 2023
18 of 19 checks passed
@fmauch fmauch deleted the prerelease/1.3.4 branch September 25, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants