Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point bdwgc submodule to commit that includes prefetch on MSVC #1698

Open
wants to merge 2 commits into
base: unity-main
Choose a base branch
from

Conversation

sschoener
Copy link

@sschoener sschoener commented Dec 10, 2022

  • Should this pull request have release notes?
    • Yes
    • No
  • Do these changes need to be back ported?
    • Yes
    • No
  • Do these changes need to be upstreamed to mono/mono or dotnet/runtime repositories?
    • Yes
    • No

Reviewers: please consider these questions as well! ❤️

@richardkettlewell
Copy link

i think you arent handling NO_PREFETCH properly anymore.

@sschoener
Copy link
Author

@richardkettlewell Thanks! Grepping for this also revealed that gc_inline.h is also defining the prefetch macros separately, so this probably needs to be fixed up as well.

@sschoener sschoener marked this pull request as ready for review January 10, 2023 11:15
@joncham
Copy link
Member

joncham commented Jan 10, 2023

Thanks for this work @sschoener ! I added a comment to the bdwgc change; my only worry is that this may clash with recent @jem-patel ARM64 work. I would suggest rebasing this PR on top of unity-main to ensure the Win ARM64 target continues to build.

Additionally, this change will eventually impact IL2CPP once we bump the submodule there. I will kick off a test run with these change in IL2CPP as well. cc @joshpeterson

@joncham
Copy link
Member

joncham commented Jan 10, 2023

cc @TautvydasZilys as well

@unity-cla-assistant
Copy link
Collaborator

unity-cla-assistant commented Aug 17, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Sebastian Schöner seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants