Update TWAMM.sol #62
Open
Update TWAMM.sol #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, this PR made 2 types of changes and these changes feels like valid as far as I am concerned. If not then do let me know and tell the reason which will be another great learning experience. Anyways let's dive into the changes made:
1. Struct Packing: As we know, that solidity use slots and the usage of it really affects the gas (means more the slots more gas used by the contract). I have noticed that rest of the
structswere perfectly packed but not this one. Earlier it was using 4 slots and now decreased to 3.2. Changed
bool [variable-name] = false;tobool [variable-name];: Not really sure about this change (looks like it's been done on purpose) but while I was going through the repository, there were several examples of unsigned integers not initialized to any value, thus leaving their value as 0 by default. And, same concept applies to this boolean variable. When not initialized, it's default value gonna be false