Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FullRange Hook Bug Fixes #128

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Jun1on
Copy link
Contributor

@Jun1on Jun1on commented Jun 24, 2024

Related Issue

  1. someone can externally call beforeInitialize and overwrite the poolToken
  2. function _rebalance is public
  3. fees can easily be yoinked

Description of changes

  1. add onlyByManager
  2. rename _rebalance -> rebalance
  3. rebalance before add liquidity and mint the user the proportional of liquidity*totalSupply/getLiquidity(poolId) instead of liquidity

@Jun1on Jun1on linked an issue Jun 24, 2024 that may be closed by this pull request
@Jun1on Jun1on marked this pull request as draft June 24, 2024 18:22
@Jun1on Jun1on linked an issue Jun 24, 2024 that may be closed by this pull request
@Jun1on Jun1on changed the title FullRange access control FullRange Hook Bug Fixes Jun 24, 2024
@Jun1on Jun1on marked this pull request as ready for review June 26, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants