Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method for plotting a range on a SkewT #2444

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dopplershift
Copy link
Member

Description Of Changes

This adds a plot_vertical_range method to SkewT to allow plotting up an indicator of a vertical range of interest, similar to those done in NSHARP/SHARPpy:

image

The code to add to our Advanced_example.py for that image are:

skew.plot_vertical_range(lcl_pressure, lfc_pressure, 0.25)
skew.ax.text(0.25, lfc_pressure - 20 * units.hPa, 'CIN 250 J/kg', ha='center',
             fontdict={'size': 'large'}, transform=skew.ax.get_yaxis_transform())

skew.plot_vertical_range(105, 260, 0.4, width=0.06, colors=['tab:red'], linewidths=[3, 1.5, 1.5])
skew.ax.text(0.42, 180, 'No Data', color='tab:red', fontdict={'size': 'large'},
             transform=skew.ax.get_yaxis_transform())

As you can see, the labels right now are added by hand. So the todo's and questions to be answered are:

  • naming? I'm not sure how I feel about plot_vertical_range(). draw_vertical_range()? Is a "vertical range" even the right terminology?
  • Is it worth adding labelling? To what extent? Depending on how much control we add, it could really bloat the API.
  • add tests
  • Include in example(s) (?)

Checklist

  • Tests added
  • Fully documented

@dopplershift dopplershift added Type: Enhancement Enhancement to existing functionality Area: Plots Pertains to producing plots labels Apr 19, 2022
@dopplershift dopplershift added this to the May 2022 milestone Apr 19, 2022
@ejt4m8
Copy link

ejt4m8 commented Apr 19, 2022

Perhaps a more appropriate name would be draw_vertical_depth() or plot_vertical_depth ? Maybe evenplot_vertical_layer ? Just some initial thoughts.

@dopplershift dopplershift modified the milestones: May 2022, July 2022 Jun 1, 2022
@dopplershift dopplershift removed this from the October 2022 milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Plots Pertains to producing plots Type: Enhancement Enhancement to existing functionality
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants