Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base models #11

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Base models #11

wants to merge 4 commits into from

Conversation

maxalmazov
Copy link
Collaborator

No description provided.

@maxalmazov maxalmazov marked this pull request as draft July 22, 2024 14:10
@maxalmazov maxalmazov marked this pull request as ready for review July 23, 2024 12:43
zaharenka
zaharenka reviewed Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@zaharenka zaharenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to double check if we need create models that don't have any entries in JSON's provided by @holdorph

models/staging/edfi_3/base/base_ef3__rubric_dimensions.sql Outdated Show resolved Hide resolved
models/staging/edfi_3/base/base_ef3__restraint_events.sql
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@holdorph said we don't need to create models for empty JSON files...but maybe i missed something

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but there is such API in docs

models/staging/edfi_3/base/base_ef3__people.sql Outdated Show resolved Hide resolved
@maxalmazov
Copy link
Collaborator Author

@holdorph all models in this pull request have API endpoint but empty json files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaharenka zaharenka zaharenka left review comments

@holdorph holdorph Awaiting requested review from holdorph

@vzakharko vzakharko Awaiting requested review from vzakharko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxalmazov @zaharenka