Even more comments #6
Conversation
Miepee
force-pushed
the
even-more-comments
branch
from
a2e0acc
to
7a123fa
Compare
| /// Optionally, <see cref="ParallelOptions"/> can be passed in to configure parallelization. | ||
| /// By default, the default settings are used (which has no limits). | ||
| /// By default, the default settings are used (which have no limits). TODO: no limits on what??? |
There was a problem hiding this comment.
Was just specifying that the default ParallelOptions has no limit on the amount of threads it can use. Also yeah, maybe could abstract out the inner loop into a private function that can be called with a regular foreach? (in an overload)
There was a problem hiding this comment.
i meant the overload more because of options = null.
There was a problem hiding this comment.
I'd rather resolve this before putting TODOs straight into the summary, lol.
| } | ||
| break; | ||
| } | ||
| // TODO: default case? |
There was a problem hiding this comment.
This is just instruction pattern matching, it falls through to the return null; afterwards if none of the conditions fully succeed.
There was a problem hiding this comment.
not what i meant. the todo was specifically referring to "Explicitly document all expected paths, and reserve default for unexpected value"
There was a problem hiding this comment.
I'm still not sure why this needs to be here. The default case just means there's no function name to be found.
Underanalyzer/Decompiler/Warnings/DecompileDataLeftoverWarning.cs
Outdated
Show resolved
Hide resolved
Miepee
force-pushed
the
even-more-comments
branch
from
7a123fa
to
ffc772d
Compare
| } | ||
| break; | ||
| } | ||
| // TODO: default case? |
There was a problem hiding this comment.
I'm still not sure why this needs to be here. The default case just means there's no function name to be found.
| /// Optionally, <see cref="ParallelOptions"/> can be passed in to configure parallelization. | ||
| /// By default, the default settings are used (which has no limits). | ||
| /// By default, the default settings are used (which have no limits). TODO: no limits on what??? |
There was a problem hiding this comment.
I'd rather resolve this before putting TODOs straight into the summary, lol.
No description provided.