Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Add Multiprecision Support #374

Draft
wants to merge 71 commits into
base: main
Choose a base branch
from
Draft

DRAFT: Add Multiprecision Support #374

wants to merge 71 commits into from

Conversation

philipc2
Copy link
Member

Closes #XXX

Overview

Expected Usage

import uxarray as ux

grid_path = "/path/to/grid.nc"
data_path = "/path/to/data.nc"

uxds = ux.open_dataset(grid_path, data_path)

# this is how you use this function
some_output = uxds.some_function()

# this is another way to use this function
other_output = uxds.some_function(some_param = True)

PR Checklist

General

  • An issue is linked created and linked
  • Add appropriate labels
  • Filled out Overview and Expected Usage (if applicable) sections

Testing

  • Adequate tests are created if there is new functionality
  • Tests cover all possible logical paths in your function
  • Tests are not too basic (such as simply calling a function and nothing else)

Documentation

  • Docstrings have been added to all new functions
  • Docstrings have updated with any function changes
  • Internal functions have a preceding underscore (_) and have been added to docs/internal_api/index.rst
  • User functions have been added to docs/user_api/index.rst

Examples

  • Any new notebook examples added to docs/examples/ folder
  • Clear the output of all cells before committing
  • New notebook files added to docs/examples.rst toctree
  • New notebook files added to new entry in docs/gallery.yml with appropriate thumbnail photo in docs/_static/thumbnails/

hongyuchen1030 and others added 30 commits May 17, 2023 21:13
…ection_through_verts' into multiprecision_unique_coords_detection_through_verts
…ection_through_verts' into multiprecision_unique_coords_detection_through_verts
@philipc2 philipc2 added new feature New feature or request multiprecision Arbitrary-precision Arithmetic Implementations labels Jul 12, 2023
@philipc2
Copy link
Member Author

@hongyuchen1030 @aaronzedwick

I have created this all-encompassing PR for merging multi_precision into main when the time comes.

I have also changed the branch protection for multi_precision to only require 1 reviewer for now to speed up development. Merging into main will still require two.

@hongyuchen1030
Copy link
Contributor

@hongyuchen1030 @aaronzedwick

I have created this all-encompassing PR for merging multi_precision into main when the time comes.

I have also changed the branch protection for multi_precision to only require 1 reviewer for now to speed up development. Merging into main will still require two.

Thank you very much for your great help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multiprecision Arbitrary-precision Arithmetic Implementations new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants