Remove TODO comment that cannot be done #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After finishing work on HPC-9121, ticket HPC-9637 was opened to track how we can set column `latestVersionId` in `project` table to be `NOT NULL`. But, turns out that will not be possible, so we need this check, cannot remove it, as TODO desired.
Pl217
added
the
ready for review
enxtur
approved these changes
Jul 10, 2024
enxtur
added
ready for merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After finishing work on HPC-9121, ticket HPC-9637 was opened to track how we can set column
latestVersionIdinprojecttable to beNOT NULL. But, turns out that will not be possible, so we need this check, cannot remove it, as TODO desired.