Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: config in updates #117

Merged
merged 6 commits into from
Jun 25, 2024
Merged

Conversation

lazysoundsystem
Copy link
Contributor

Refs: OPS-10254

This now works: #115

This includes the common design subtheme, as it's need to import the config.

The other change is to use the https://github.com/UN-OCHA/actions/tree/OPS-10254-config-too branch - that will change when that branch is merged.

One other change - to include AWS secrets - has already been merged to develop #114

Copy link

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions PHP 8.2.20 (cli) (built: Jun 6 2024 17:46:29) (NTS) Copyright (c) The PHP Group Zend Engine v4.2.20, Copyright (c) Zend Technologies with Zend OPcache v8.2.20, Copyright (c), by Zend Technologies with Xdebug v3.3.2, Copyright (c) 2002-2024, by Derick Rethans Composer version 2.7.7 2024-06-10 22:11:12
Drupal Logs

Pusher: @lazysoundsystem, Action: pull_request, Workflow: Run tests

Copy link
Contributor

@cafuego cafuego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, it still deletes most of the config for Sesame when I run the update job with these steps, so it needs work.

I don't know why it deletes that config, though. The initial install certainly imports it :-/

Copy link

Coverage Report

Totals Coverage

@lazysoundsystem
Copy link
Contributor Author

I know the action is not working yet for Sesame, but I'm hoping merging this to develop might fix https://github.com/UN-OCHA/drupal-starterkit/actions/runs/9594671122

@lazysoundsystem lazysoundsystem merged commit 5f46e45 into develop Jun 25, 2024
2 checks passed
@cafuego cafuego deleted the OPS-10254-config-in-updates branch June 25, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants