Fix issue with threads named 'deleted-channel' #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. This works, but pulling threads for an entire guild is notoriously slow. |
|
Thanks for the feedback! I've updated my code to only fetch the necessary channel. Please check again. |
Tyrrrz
reviewed
Sep 14, 2024
Refactor to remove the null check in populate function Co-authored-by: Oleksii Holub <[email protected]>
Refactor to null check at callsite Co-authored-by: Oleksii Holub <[email protected]>
|
Please run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1261
I tried to solve the problem with the thread labeled 'deleted-channel' by using populate threads before assigning the channel variable in the mention.