Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore output colors when TERM is dumb #300

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Ignore output colors when TERM is dumb #300

wants to merge 7 commits into from

Conversation

Chemaclass
Copy link
Member

@Chemaclass Chemaclass commented Jul 23, 2024 •
edited
Loading

📚 Description

Original idea: #247 (comment) by @h0adp0re

✅ To-do list

  • I updated the CHANGELOG.md to reflect the new feature or fix

I am not 100% sure I like the changes. I think it's good to have the colors in the snapshots... any other thoughts?

@Chemaclass Chemaclass added the enhancement New feature or request label Jul 23, 2024
@Chemaclass Chemaclass self-assigned this Jul 23, 2024
@Chemaclass Chemaclass marked this pull request as draft July 23, 2024 13:00
@staabm
Copy link
Contributor

staabm commented Sep 22, 2024

btw: there is a "standard", see https://no-color.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmayo cmayo Awaiting requested review from cmayo

@khru khru Awaiting requested review from khru

@JesusValera JesusValera Awaiting requested review from JesusValera

@antonio-gg-dev antonio-gg-dev Awaiting requested review from antonio-gg-dev

@fabriziofs fabriziofs Awaiting requested review from fabriziofs

At least 1 approving review is required to merge this pull request.

Assignees

@Chemaclass Chemaclass

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Chemaclass @staabm