warning: this `if` branch is empty --> src/cbcast/cbclock.rs:72:9 | 72 | if first.is_some() {} | ^^^^^^^^^^^^^^^^^^^^^ help: you can remove it: `first.is_some();` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_if = note: `#[warn(clippy::needless_if)]` on by default

warning: non-canonical implementation of `partial_cmp` on an `Ord` type --> src/cbcast/cbclock.rs:29:1 | 29 | / impl<T: Eq + Hash + Display> PartialOrd for CbcastClock<T> { 30 | | fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> { | | _______________________________________________________________________- 31 | || let mut ordering: Ordering = Ordering::Equal; 32 | || let other_len = other.vc.len(); 33 | || let mut cur_len = 0; ... || 50 | || } 51 | || } | ||_____- help: change this to: `{ Some(self.cmp(other)) }` 52 | | } | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

warning: this `if` branch is empty --> src/cbcast/cbclock.rs:72:9 | 72 | if first.is_some() {} | ^^^^^^^^^^^^^^^^^^^^^ help: you can remove it: `first.is_some();` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_if = note: `#[warn(clippy::needless_if)]` on by default

warning: non-canonical implementation of `partial_cmp` on an `Ord` type --> src/cbcast/cbclock.rs:29:1 | 29 | / impl<T: Eq + Hash + Display> PartialOrd for CbcastClock<T> { 30 | | fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> { | | _______________________________________________________________________- 31 | || let mut ordering: Ordering = Ordering::Equal; 32 | || let other_len = other.vc.len(); 33 | || let mut cur_len = 0; ... || 50 | || } 51 | || } | ||_____- help: change this to: `{ Some(self.cmp(other)) }` 52 | | } | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default