🧑💻 Replace user details by LightUserResource in LeaderboardUserResource
#2635
Conversation
marhei
changed the title
LeaderboardUserResource
|
Maybe some also needs to recreate the API docs, I don't know how this works… |
| 'id' => (int) $this->user->id, | ||
| 'displayName' => (string) $this->user->name, | ||
| 'username' => (string) $this->user->username, | ||
| 'profilePicture' => ProfilePictureController::getUrl($this->user), |
There was a problem hiding this comment.
Maybe we can include the LightUserResource here. This reduced the amount of different resources with similar attributes.
What do you think?
There was a problem hiding this comment.
I would prefer my proposed implementation because it fits better into my existing implementation of the user model.
MrKrisKrisu
changed the title
LeaderboardUserResourceLeaderboardUserResource
|
@MrKrisKrisu As you wanted: |
marhei
changed the title
LeaderboardUserResourceLightUserResource in LeaderboardUserResource
marhei
changed the title
LightUserResource in LeaderboardUserResourceLightUserResource in LeaderboardUserResource
There was a problem hiding this comment.
Thanks for the change. But maybe we should get a third opinion before we just blindly change something just because I like it more?
(@HerrLevin?)
|
@HerrLevin May I be merged? 🥺👉👈 |
|
@marhei I know where you're coming from. From a client pov I would prefer the original user pov. But I know our code and our database... This would most likely impact our performance (which we don't have :D) severely 🥴 I'm fine with the PR as it is currently, if you revert the two code occurences I've mentioned in my review. /cc @MrKrisKrisu |
|
I removed all unwanted changes, thanks for the review! |
To provide the same basic informations across all user resources