Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue #307 #444

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Conversation

vguzman812
Copy link
Contributor

@vguzman812 vguzman812 commented Aug 21, 2023

Description

Solves issue # 307 which asks for a heading tag in the event description modal.

Type of change

Please select everything applicable. Please, do not delete any lines.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change requires an update to testing

Issue

Checklist:

  • This PR is up to date with the main branch, and merge conflicts have been resolved
  • I have executed npm run test and all tests have passed successfully or I have included details within my PR on the failure.
  • I have executed npm run lint and resolved any outstanding errors. Most issues can be solved by executing npm run format
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

…iption. Change margin classes of description div and the description heading to better reflect desired layout found in issue examples. Solves issue Together-100Devs#307.
@vguzman812 vguzman812 temporarily deployed to DEV August 21, 2023 18:17 — with GitHub Actions Inactive
@Caleb-Cohen Caleb-Cohen merged commit 52bb068 into Together-100Devs:main Aug 21, 2023
1 check passed
@Caleb-Cohen
Copy link
Member

LGTM! Thanks for taking this on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants