-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/admin dashboard event visualization 407 #431
Feature/admin dashboard event visualization 407 #431
Conversation
Code looks good. Should we consider additional testing? For example: insert event into DB, does it visualize? |
- Check for new event added - Check for updated event count
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, what are your thoughts on deleting the event and checking if it no longer exists?
My thinking is that I should be able to send a DELETE to the Then the rendering check can loop through any remaining notes and confirm the note with the target I should be able to take a look at it in the next couple days and let you know if I run into any issues with that method. |
That's how I would approach it! |
- The "Add Events" tests now accepts a list of event obects - Setup was also refactored into a `before()` and `beforeEach()` for consistency
LGTM Thanks for taking this on! |
Description
Display all current events on Admin Dashboard. The AdminDashboard page now loads all current events and displays them in a list. The page initially loads all the current events automatically, but any subsequent refreshes must use the "Refresh Events" button in the top right.
NOTE: All tests passed for the first two commits cdd0cd7 and cbfaa9f. However, the Admin dashboard cannot currently be accessed while running the development build due to an old
/calendar
redirect inclient/src/contexts/AuthContext/useProvideAuth.js
. The latest commit d6db77b removes this redirect for testing the Admin Dashboard, but some adjustments will need to be made to the relevant failing tests.I've attached test-events.zip with a json file that can be imported into the
events
Mongo collection to test the loading animation with a large set of events.Type of change
Please select everything applicable. Please, do not delete any lines.
Issue
getAll
#407Checklist:
npm run test
and all tests have passed successfully or I have included details within my PR on the failure.npm run lint
and resolved any outstanding errors. Most issues can be solved by executingnpm run format