Groups: don't try to load metadata on client open requests. #4508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes sure that the client doesn't try to load the group metadata client side when doing a REST request that will end up returning the group metadata. This would actually end up causing two REST requests, one to the load metadata route, then one to the group open route. --- TYPE: NO_HISTORY DESC: Groups: don't try to load metadata on client open requests.
robertbindar
approved these changes
Nov 10, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 10, 2023
This change makes sure that the client doesn't try to load the group metadata client side when doing a REST request that will end up returning the group metadata. This would actually end up causing two REST requests, one to the load metadata route, then one to the group open route. --- TYPE: NO_HISTORY DESC: Groups: don't try to load metadata on client open requests. (cherry picked from commit a648a7e)
KiterLuc
added a commit
that referenced
this pull request
Nov 10, 2023
…open requests. (#4509) Backport a648a7e from #4508. Co-authored-by: KiterLuc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes sure that the client doesn't try to load the group metadata client side when doing a REST request that will end up returning the group metadata. This would actually end up causing two REST requests, one to the load metadata route, then one to the group open route.
TYPE: NO_HISTORY
DESC: Groups: don't try to load metadata on client open requests.