Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove function sanity_check() for contexts #4506

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

eric-hughes-tiledb
Copy link
Contributor

The function sanity_check() for contexts has returned a constant TILEDB_OK for a while now; that check was moved into the exception wrappers. At the time, the function was stubbed out to avoid combining the large number of lines that would change with other, more significant ones. This PR completes the removal of this function.


TYPE: NO_HISTORY
DESC: Remove function sanity_check() for contexts

The function `sanity_check()` for contexts has returned a constant `TILEDB_OK` for a while now; that check has moved into the exception wrappers. At the time, the function was stubbed out to avoid combining the large number of lines that would change with other, more significant one. This PR completes the removal of this function.
Copy link
Contributor

@davisp davisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davisp
Copy link
Contributor

davisp commented Nov 9, 2023

I was confused about the CI error so I went and looked and it appears to be at least one spot where the only use of ctx in the function was passing it to the sanit_check function you removed:

/home/runner/work/TileDB/TileDB/tiledb/sm/c_api/tiledb.cc: In function ‘int32_t tiledb::api::tiledb_uri_to_path(tiledb_ctx_t*, const char*, char*, uint32_t*)’:
/home/runner/work/TileDB/TileDB/tiledb/sm/c_api/tiledb.cc:3258:19: error: unused parameter ‘ctx’ [-Werror=unused-parameter]
 3258 |     tiledb_ctx_t* ctx, const char* uri, char* path_out, uint32_t* path_length) {
      |     ~~~~~~~~~~~~~~^~~

@eric-hughes-tiledb
Copy link
Contributor Author

unused parameter

I had a mismatch in capnp version because vcpkg dependencies apparently don't propagate to become dependencies of targets. tiledb.cc was failing in this way so I didn't see the error locally. Fixed that, and saw that it was the only occurrence.

@KiterLuc KiterLuc merged commit 52c4525 into dev Nov 13, 2023
55 checks passed
@KiterLuc KiterLuc deleted the eh/remove-sanity-check-for-context branch November 13, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants