Use find_package for the compression libraries when vcpkg is enabled.
#4500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The targets were renamed to match the casing.
We cannot use an alias target to choose the correct linkage for zstd, as long as `TILEDB_INSTALL_STATIC_DEPS` exists.
teo-tsirpanis
force-pushed
the
find_package-compressors
branch
from
7d96967
to
45a9949
Compare
|
Am I reading this correctly as in " |
|
No, the libraries will still be provided by vcpkg. The ports for lz4 and zstd provide CMake config files that will be directly used by
|
KiterLuc
approved these changes
Nov 13, 2023
KiterLuc
pushed a commit
that referenced
this pull request
Nov 16, 2023
> [!NOTE] > ~~Depends on #4500.~~ [SC-36531](https://app.shortcut.com/tiledb-inc/story/36531/remove-tiledb-install-static-deps) This PR removes the now-unused `TILEDB_INSTALL_STATIC_DEPS` option and all the infrastructure supporting it. This frees us from having to reason about the dependencies of our dependencies (at least when vcpkg is enabled), and allows us to more easily update libraries in the future (for example updating Curl after that will be a piece of cake). Instead of installing our static dependencies, we let the consuming project find them at configure time through the [`find_dependency`](https://cmake.org/cmake/help/latest/module/CMakeFindDependencyMacro.html) command[^1]. This matches what [other](https://github.com/Azure/azure-sdk-for-cpp/blob/0ca8a1d9d5726be74ba0985e69c711af6b4a89b2/sdk/core/azure-core/vcpkg/Config.cmake.in#L6-L19) [CMake](https://github.com/curl/curl/blob/9fb6cc54c59760bee23c730f668653895e713a25/CMake/curl-config.cmake.in#L26-L32) [libraries](https://github.com/googleapis/google-cloud-cpp/blob/43c6142d5b802deb07f8e3094e13367a6219a844/google/cloud/config.cmake.in#L15-L18) do. I tested this by successfully running the static linkage tests. I also ran a full build with every feature enabled and vcpkg disabled, to make sure the legacy build does not get broken, and will also trigger a nightly build run. [^1]: One possible place to find them is vcpkg; in fact this is what we do in the static linkage tests: we pass `vcpkg_installed` to the CMake prefix path, and all these calls to `find_dependency` will be resolved from there. --- TYPE: BUILD DESC: Remove bundling our static library dependencies; they are now found from the CMake config file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of our compression libraries provide native CMake integration with
find_package. This PR makes use of it when vcpkg is enabled.TYPE: BUILD
DESC: Use the provided CMake packages to import the compression libraries when vcpkg is enabled.