Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements to the GCS VFS. #4008

Closed
wants to merge 22 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
ce63be0
Unstatus `GCS::parse_gcs_uri` and make it static and returning a tuple.
teo-tsirpanis Mar 29, 2023
7eed8a7
Remove polling for bucket/object propagation/deletion.
teo-tsirpanis Mar 29, 2023
c9d0720
Fix typo.
teo-tsirpanis Mar 30, 2023
825e3fa
Use references more.
teo-tsirpanis Mar 30, 2023
7073af0
Create vectors with preallocated size.
teo-tsirpanis Mar 30, 2023
0152be2
Take advantage of the MaxResults option in listing operations.
teo-tsirpanis Mar 30, 2023
11bd496
Copy the GCS client object before using it.
teo-tsirpanis Mar 30, 2023
9c49db5
Bring back a mutex unlock that was accidentally removed.
teo-tsirpanis Apr 7, 2023
509c693
Update the vcpkg submodule.
teo-tsirpanis Apr 7, 2023
925ed6e
Update the Google Cloud SDK to its latest version.
teo-tsirpanis Apr 7, 2023
413cbf1
Use the zero-copy `InsertObject` overload.
teo-tsirpanis Apr 7, 2023
78feba7
Remove `GCSSDK_EP`.
teo-tsirpanis Apr 7, 2023
fb9bbe3
Remove direct dependency to abseil.
teo-tsirpanis Apr 7, 2023
e26e644
Revert "Remove direct dependency to abseil."
teo-tsirpanis Apr 7, 2023
ed215ae
Use RAII to release locks.
teo-tsirpanis Apr 18, 2023
65989c0
Revert "Create vectors with preallocated size."
teo-tsirpanis Mar 30, 2023
1cc5803
Fix typo.
teo-tsirpanis Apr 18, 2023
54ed3e8
Clarify the code a bit.
teo-tsirpanis Apr 18, 2023
a778a20
Add specific tags to two GCS tests.
teo-tsirpanis Apr 19, 2023
d223df2
Bring back the custom port for abseil and update the one for google-c…
teo-tsirpanis Apr 19, 2023
aff3deb
Use zero-copy writes in one more case.
teo-tsirpanis Apr 20, 2023
3d81d38
Merge branch 'dev' into gcs-improvements
teo-tsirpanis Nov 13, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/src/unit-gcs.cc
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ std::string GCSFx::random_bucket_name(const std::string& prefix) {
return ss.str();
}

TEST_CASE_METHOD(GCSFx, "Test GCS init", "[gcs]") {
TEST_CASE_METHOD(GCSFx, "Test GCS init", "[gcs][init]") {
try {
Config config;
REQUIRE(config.set("vfs.gcs.use_multi_part_upload", "true").ok());
Expand All @@ -120,7 +120,7 @@ TEST_CASE_METHOD(GCSFx, "Test GCS init", "[gcs]") {
}
}

TEST_CASE_METHOD(GCSFx, "Test GCS filesystem, file management", "[gcs]") {
TEST_CASE_METHOD(GCSFx, "Test GCS filesystem, file management", "[gcs][fs]") {
Config config;
REQUIRE(config.set("vfs.gcs.use_multi_part_upload", "true").ok());
init_gcs(std::move(config));
Expand Down
Loading
Loading