Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NW.js to 0.84.0, released 2024-02-05 #293

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

rmunn
Copy link
Contributor

@rmunn rmunn commented Mar 3, 2024

NW.js 0.84.0 comes with Chromium 121.0.6167.139 and Node 21.1.0.

Fixes #292.

NW.js 0.84.0 comes with Chromium 121.0.6167.139 and Node 21.1.0.
@rmunn
Copy link
Contributor Author

rmunn commented Mar 3, 2024

With the new CI infrastructure it's literally as easy as changing a single file to update the nw.js version included in TiddlyDesktop. Previously you would have had to edit multiple lines in both download-nwjs.sh and bld.sh, but now they all get their data from a single source of truth.

@Jermolene Jermolene merged commit bbb9f99 into TiddlyWiki:master Mar 3, 2024
7 checks passed
@Jermolene
Copy link
Member

Thanks @rmunn – I'm going to try to make another release, this time I'm using a mobile device on a train, so will be good practice.

@Jermolene
Copy link
Member

Hi @rmunn I used a slightly different procedure because of being on mobile:

  1. Edit package.json via GH web interface
  2. Create a draft release, assigning the vX.X.X tag at the same time

I think you won't be able to see the draft release, but it is not showing any files. I do see the build products if I inspect the action.

@rmunn
Copy link
Contributor Author

rmunn commented Mar 3, 2024

I only set it up to create a draft release when a tag is pushed, not when it's created. If you create the tag via the GItHub web UI then it doesn't count as a push. When you get home, you should be able to git push origin :v0.0.21 (note the colon) to delete the tag, then git tag v0.0.21 and git push v0.0.21 to push it again, and that should trigger the draft release getting created and the files uploaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version of nw.js is old
2 participants