Fix: TOC observer race condition when disconnecting. #4012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because: * With turbo caching enabled we need to tear down the lessons table of contents(toc) before the page is cached. We were doing this by unobserving each toc item. However, in some cases this wasn't finishing fast enough and was trying to unobserve toc items after they'd already been destroyed - resulting in an exception being thrown. This commit: * Create the toc intersection observer on connect and assign it as a controller attribute. * Disconnect the entire observer instead of unobserving each item.
KevinMulhern
added
the
Type: Bug
ChargrilledChook
approved these changes
Jul 22, 2023
| this.lessonContentTarget.querySelectorAll('section[id]').forEach((section) => { | ||
| this.tocItemObserver().observe(section); | ||
| this.observer.observe(section); |
Mclilzee
pushed a commit
to Mclilzee/theodinproject
that referenced
this pull request
Aug 2, 2023
…4012) Because: * With turbo caching enabled we need to tear down the lessons table of contents(toc) before the page is cached. We were doing this by unobserving each toc item. However, in some cases this wasn't finishing fast enough and was trying to unobserve toc items after they'd already been destroyed - resulting in an exception being thrown. This commit: * Create the toc intersection observer on connect and assign it as a controller attribute. * Disconnect the entire observer instead of unobserving each item.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
This commit: