Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Solutions blank state #4007

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Feature: Solutions blank state #4007

merged 1 commit into from
Jul 21, 2023

Conversation

KevinMulhern
Copy link
Member

Because:

  • When there are no solutions we should prompt the learner to add one.

This commit:

  • Adds a blank state to be displayed when there are no solutions.
  • Adds logic for adding/removing the blank state when the user adds/removes their solution.
  • Included some responsive fixes for solution items.
Screenshot 2023-07-21 at 00 44 39

@KevinMulhern
Feature: Solutions blank state
a058667 
Because:
* When there are no solutions we should prompt the learner to add one.

This commit:
* Adds a blank state to be displayed when there are no solutions.
* Adds logic for adding/removing the blank state when the user adds/removes their solution.
* Included some responsive fixes for solution items.
@KevinMulhern KevinMulhern self-assigned this Jul 21, 2023
@KevinMulhern KevinMulhern added the Type: Enhancement Involves a new feature or enhancement request label Jul 21, 2023
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4007 July 21, 2023 00:38 Inactive
@KevinMulhern KevinMulhern mentioned this pull request Jul 21, 2023
Closed
@KevinMulhern KevinMulhern merged commit 36f9cb1 into main Jul 21, 2023
2 checks passed
@KevinMulhern KevinMulhern deleted the feature/solutions-blank-state branch July 21, 2023 13:45
Mclilzee pushed a commit to Mclilzee/theodinproject that referenced this pull request Aug 2, 2023
@KevinMulhern @Mclilzee
Feature: Solutions blank state (TheOdinProject#4007)
47a766a 
Because:
* When there are no solutions we should prompt the learner to add one.

This commit:
* Adds a blank state to be displayed when there are no solutions.
* Adds logic for adding/removing the blank state when the user
adds/removes their solution.
* Included some responsive fixes for solution items.

<img width="1322" alt="Screenshot 2023-07-21 at 00 44 39"
src="https://github.com/TheOdinProject/theodinproject/assets/7963776/14f4047c-a6fc-4d80-8423-36f5a54e03a3">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CouchofTomato CouchofTomato CouchofTomato approved these changes

Assignees

@KevinMulhern KevinMulhern

Labels
Type: Enhancement Involves a new feature or enhancement request
Projects
Main Site
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KevinMulhern @CouchofTomato