Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Change React badges to 100% width and height #3996

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Fix: Change React badges to 100% width and height #3996

merged 1 commit into from
Jul 17, 2023

Conversation

zachmmeyer
Copy link
Contributor

Because

The React Badges are off center

This PR

Fixes those React Badges by changing their width and height values to 100% instead of 104

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the keyword: brief description of change format, using one of the following keywords:
  • Feature - adds new or amends existing user-facing behavior
  • Chore - changes that have no user-facing value, refactors, dependency bumps, etc
  • Fix - bug fixes
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • I have verified all tests and linters pass after making these changes.
  • If this PR addresses an open issue, it is linked in the Issue section
  • If applicable, this PR includes new or updated automated tests

@zachmmeyer zachmmeyer added the Status: Needs Review This issue/PR needs an initial or additional review label Jul 17, 2023
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-3996 July 17, 2023 23:28 Inactive
@zachmmeyer
Copy link
Contributor Author

image
image

ChargrilledChook
ChargrilledChook approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@ChargrilledChook ChargrilledChook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Feature, not a bug...?

Nice catch LGTM 🚀

@zachmmeyer zachmmeyer merged commit 2901859 into main Jul 17, 2023
2 checks passed
@zachmmeyer zachmmeyer deleted the fix-react-badges branch July 17, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChargrilledChook ChargrilledChook ChargrilledChook approved these changes

Assignees
No one assigned
Labels
Status: Needs Review This issue/PR needs an initial or additional review
Projects
Main Site
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zachmmeyer @ChargrilledChook @KevinMulhern