-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Move Dashboard project solutions to Hotwire. #3967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinMulhern
added
the
Type: Enhancement
Involves a new feature or enhancement request
label
Jul 14, 2023
KevinMulhern
force-pushed
the
feature/convert-user-solutions-to-hotwire
branch
from
July 14, 2023 14:05
08af4cd
to
355ae5f
Compare
@KevinMulhern Few conflicts on this one |
KevinMulhern
force-pushed
the
feature/convert-user-solutions-to-hotwire
branch
from
July 16, 2023 20:26
355ae5f
to
f62041e
Compare
Thanks @ChargrilledChook, those should be sorted now. |
KevinMulhern
force-pushed
the
feature/convert-user-solutions-to-hotwire
branch
from
July 21, 2023 14:13
f62041e
to
f252410
Compare
Because: * We are replacing our React components with Hotwire. This commit: * Adds a title slot to project submission items - we display the lesson title when on the dashboard and the solutions users name when on a lesson page. * Adds a users project submissions controller - when updating a solution from the dashboard we need to use a user specific endpoint to ensure the correct solution item is returned. * Automatically like your own project when it is created - We need to disable liking your own submissions, at least for now: * The likes endpoint needs to return a full item component at the moment to allow sorting to work. This conflicts with needing different item titles on the dashboard and lesson pages. We'll be able to enable again soon ™️. The next phase of this project is to add a sorting feature to the solutions list, we'll be able to update just the like counter when that is built. * The compromise is to automatically like your project so nobody ever has to see their project sitting at 0 - kind of like how Reddit handles new posts. * A few performance improvements by preloading lesson and user solutions when fetching solutions.
KevinMulhern
force-pushed
the
feature/convert-user-solutions-to-hotwire
branch
from
July 21, 2023 16:41
f252410
to
8979109
Compare
CouchofTomato
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed on mobile so apologies if I missed anything in the review
Mclilzee
pushed a commit
to Mclilzee/theodinproject
that referenced
this pull request
Aug 2, 2023
…#3967) Because: * We are replacing our React components with Hotwire. This commit: * Adds a title slot to project submission items - we display the lesson title when on the dashboard and the solutions users name when on a lesson page. * Adds a users project submissions controller - when updating a solution from the dashboard we need to use a user specific endpoint to ensure the correct solution item is returned. * Automatically like your own project when it is created - We need to disable liking your own submissions, at least for now: * The likes endpoint needs to return a full item component at the moment to allow sorting to work. This conflicts with needing different item titles on the dashboard and lesson pages. We'll be able to enable again soon ™️. The next phase of this project is to add a sorting feature to the solutions list, we'll be able to update just the like counter when that is built. * The compromise is to automatically like your project so nobody ever has to see their project sitting at 0 - kind of like how Reddit handles new posts. * A few performance improvements by preloading lesson and user solutions when fetching solutions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
This commit: