Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdownlint: Move required heading structure into TOP004 rule directly #28759

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Markdownlint: Move required heading structure into TOP004 rule directly #28759

wants to merge 7 commits into from

Commits on Sep 7, 2024

  1. Use internal headings array 

    No need to extract from separate custom config
    @MaoShizhong
    MaoShizhong committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    d93ff90 View commit details
    Browse the repository at this point in the history

  2. Remove case matching checks 

    Carryover from original rule - we always want to match case with ours
    @MaoShizhong
    MaoShizhong committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    4336687 View commit details
    Browse the repository at this point in the history

  3. Add detail field for missing heading error 

    Detail field required for VSCode extension error message - context field
alone is insufficient.
Removed ellipsify method and unused params (carryover from original rule).
    @MaoShizhong
    MaoShizhong committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    eee3939 View commit details
    Browse the repository at this point in the history

  4. Amend TOP004 test files 

    Separated lesson/project tests due to different required headings.
Separated different kinds of heading errors from lesson test file.
    @MaoShizhong
    MaoShizhong committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    0eae2cc View commit details
    Browse the repository at this point in the history

  5. Remove separate config files

    @MaoShizhong
    MaoShizhong committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    f38be46 View commit details
    Browse the repository at this point in the history

  6. Replace npm scripts without custom configs 

    Default config is .markdownlint-cli2.jsonc. Contributing guide amended accordingly.
    @MaoShizhong
    MaoShizhong committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    6224853 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Replace references to old fix:* scripts 

    TOP005 also missing a few language exceptions
    @MaoShizhong
    MaoShizhong committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    f35452a View commit details
    Browse the repository at this point in the history