Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V5 #23

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

V5 #23

wants to merge 4 commits into from

Conversation

edward-park-climate
Copy link

Demo Python app for Climate's v5 growingSeasons and harvestReports APIs

@rajindersaini
Copy link
Contributor

Can we refactor common code in a common dir?

v5/python/main.py Outdated Show resolved Hide resolved
v5/python/climate.py Outdated Show resolved Hide resolved
@edward-park-climate
Copy link
Author

Can we refactor common code in a common dir?

I created a function for the reuse of the rendering of the page. I thought about creating a function for Climate requests but thought against it because it would make it more difficult for partners to quickly see the needed information for each request.

Let me know if you think there can be more refactoring.

@rajindersaini
Copy link
Contributor

rajindersaini commented Mar 31, 2022

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants