Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support run_schedule() in panicking_world_methods lint #151

Merged
merged 1 commit into from
Oct 19, 2024
Merged

Support run_schedule() in panicking_world_methods lint #151

merged 1 commit into from
Oct 19, 2024
+15 −2

Conversation

BD103
Copy link
Member

@BD103 BD103 commented Oct 17, 2024

Closes #129.

I missed World::run_schedule() in my first pass over all panicking World methods. This fixes that, and suggests try_run_schedule() instead.

@BD103 BD103 added A-Linter Related to the linter and custom lints C-Feature Make something new possible labels Oct 17, 2024
@BD103 BD103 merged commit 1aad803 into main Oct 19, 2024
8 checks passed
@BD103 BD103 deleted the try-run-schedule branch October 19, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimJentzsch TimJentzsch TimJentzsch approved these changes

Assignees
No one assigned
Labels
A-Linter Related to the linter and custom lints C-Feature Make something new possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panicking_world_methods does not lint against World::run_schedule() vs. World::try_run_schedule()
2 participants
@BD103 @TimJentzsch