-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bug fixing and chores related to linting (#121)
This PR tackles a few issues with how `bevy_lint` functions. First, it closes #117 by passing `--cfg bevy_lint` to `rustc` when `bevy_lint` is called. This allows code to conditionally configure lints (e.g. `#[cfg_attr(bevy_lint, allow(bevy::lint))]`). Secondly, it fixes #118 by specifying the nightly version when calling `cargo check`. I originally hardcoded this version, but after a comment from @richchurcher I adjusted it to take the version from `rust-toolchain.toml`. (It specifically uses a build script to parse `rust-toolchain.toml` using `toml_edit`, then passes it to the code using an environmental variable.) Thirdly, I removed other hard-coded references to the specifically nightly channel in `README.md` and `ci.yml`. (In CI I specifically used [Taplo](https://taplo.tamasfe.dev) to parse the version, similar to [`jq`](https://jqlang.github.io/jq/).) Finally, I added a bit more metadata to `Cargo.toml` that will be used by <https://crates.io> once it is published.
- Loading branch information
Showing
8 changed files
with
171 additions
and
140 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.