Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass CancellationToken from a cancellableTask to GetAsyncEnumerator #48

Merged
merged 1 commit into from
May 8, 2024

Conversation

TheAngryByrd
Copy link
Owner

@TheAngryByrd TheAngryByrd commented May 8, 2024

Proposed Changes

#37 was missing passing the CancellationToken from a cancellableTask to GetAsyncEnumerator

Types of changes

What types of changes does your code introduce to IcedTasks?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@TheAngryByrd TheAngryByrd enabled auto-merge (squash) May 8, 2024 13:11
@TheAngryByrd TheAngryByrd disabled auto-merge May 8, 2024 13:11
@TheAngryByrd TheAngryByrd merged commit c01c152 into master May 8, 2024
9 checks passed
@TheAngryByrd TheAngryByrd deleted the cancellation-passing branch May 8, 2024 13:11
@TheAngryByrd TheAngryByrd changed the title Pass CancellationToken to GetAsyncEnumerator Pass CancellationToken from a cancellableTask to GetAsyncEnumerator May 8, 2024
TheAngryByrd added a commit that referenced this pull request May 8, 2024
## [0.11.6] - 2024-05-08

### Fixed
- [Pass CancellationToken from a cancellableTask to GetAsyncEnumerator](#48) - Credits @TheAngryByrd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant