Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile log info #2423

Merged

Conversation

oharboe
Copy link
Collaborator

@oharboe oharboe commented Oct 5, 2024

Part deux The-OpenROAD-Project/OpenROAD#5876

Manual test locally:

$ make do-2_3_floorplan_tdms 
Running tdms_place.tcl, stage 2_3_floorplan_tdms
exec cp ./results/nangate45/gcd/base/2_2_floorplan_io.odb ./results/nangate45/gcd/base/2_3_floorplan_tdms.odb
Elapsed time: 0:00.13[h:]min:sec. CPU time: user 0.10 sys 0.02 (100%). Peak memory: 100444KB.
$ head -n 10 logs/nangate45/gcd/base/2_3_floorplan_tdms.log 
OpenROAD v2.0-16257-g81b545063 
Features included (+) or not (-): +Charts +GPU +GUI +Python
This program is licensed under the BSD-3 license. See the LICENSE file for details.
Components of this program may be licensed under more restrictive licenses which must be honored.
[INFO ORD-0030] Using 12 thread(s).
exec cp ./results/nangate45/gcd/base/2_2_floorplan_io.odb ./results/nangate45/gcd/base/2_3_floorplan_tdms.odb
Elapsed time: 0:00.13[h:]min:sec. CPU time: user 0.10 sys 0.02 (100%). Peak memory: 100444KB.

flow/scripts/util.tcl Outdated Show resolved Hide resolved
@maliberty
Copy link
Member

You appear to have just wrecked this PR (all the content gone). Once you have requested a review please don't force push. It destroys the ability to see changes since the last review.

@oharboe
Copy link
Collaborator Author

oharboe commented Oct 5, 2024

You appear to have just wrecked this PR (all the content gone). Once you have requested a review please don't force push. It destroys the ability to see changes since the last review.

Normally I'm loath to force push, but in this case I had a giant commit that shouldn't be there.

From there it was a matter of picking a poison: a giant revert commit or a force push. I chose the latter.

@maliberty
Copy link
Member

The content is entirely different and doesn't seem to match the title. Is this right?

@oharboe
Copy link
Collaborator Author

oharboe commented Oct 5, 2024

The content is entirely different and doesn't seem to match the title. Is this right?

Yes, this PR is now a single concern where the title is congruent with the single(tiny) commit.

"Makefile log info": This matches the commit: tweak logging info so that the number of threads specified in "-threads" is logged into .log.

@maliberty maliberty merged commit edcd265 into The-OpenROAD-Project:master Oct 5, 2024
6 checks passed
@oharboe oharboe deleted the makefile-log-info branch October 6, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants