Fixes for rrule merger #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @Thaodan , I was interested in your rrule branch, but it didn't work for me, and also some unit tests failed.
I think these are the changes need to make the branch work.
Reading the iCalendar RFC, the section on RRULE looks quite complex, and I am unsure if this implementation is too rudimentary. I wonder if using
icalendar--convert-recurring-to-diary, as in this alternative PR, might be more robust:dengste#216
I see you commented on that PR as well so curious if you have any thoughts about it.
I'll probably hold off on merging this into my master at the moment, since I don't have a strong need for it right now, and implementing it correctly seems complex. Also, seems like VTODO RRULE's aren't handled at all, even in upstream ox-icalendar.el. Still, it'd be nice to have something like this eventually.