New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(v8): add log for call function cpp buffer fail #4010

Merged

siguangli merged 1 commit into Tencent:2.11.5_deserialize from etkmao:2.11.5_deserialize_fix

Aug 29, 2024

Collaborator

etkmao commented Aug 29, 2024

Before submitting a new pull request, please make sure:

Test cases have been added/updated/passed for the code you will submit.
Documentation has added or updated.
Commit message is following the Convention Commit guideline with maximum 72 characters.
Squash the repeat code commits, short patches are welcome.


          fix(v8): add log for call function cpp buffer fail

50d1755

etkmao requested review from ilikethese, churchill-zhang, zoomchan-cxj and siguangli as code owners

August 29, 2024 09:28

siguangli merged commit dda2c09 into Tencent:2.11.5_deserialize

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ilikethese Awaiting requested review from ilikethese ilikethese is a code owner

churchill-zhang Awaiting requested review from churchill-zhang churchill-zhang is a code owner

zoomchan-cxj Awaiting requested review from zoomchan-cxj zoomchan-cxj is a code owner

siguangli Awaiting requested review from siguangli siguangli is a code owner

Labels

None yet