Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): improve accuracy of ViewPager's onPageScroll parameters #3992

Merged
merged 2 commits into from
Aug 13, 2024
Merged

fix(ios): improve accuracy of ViewPager's onPageScroll parameters #3992

merged 2 commits into from
Aug 13, 2024

Conversation

wwwcg
Copy link
Collaborator

@wwwcg wwwcg commented Aug 13, 2024

Pre-PR Checklist

  • I added/updated relevant documentation.
  • I followed the Convention Commit guideline with maximum 72 characters to submit commit message.
  • I squashed the repeated code commits.
  • I signed the [CLA].
  • I added/updated test cases to check the change I am making.
  • All existing and new tests are passing.

@wwwcg wwwcg requested a review from ruifanyuan as a code owner August 13, 2024 13:01
@hippy-service Hippy Service
Copy link

hippy-service bot commented Aug 13, 2024

Hi, @wwwcg. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@github-actions github-actions bot added the size: s Denotes a PR that changes 10-99 lines label Aug 13, 2024
@wwwcg wwwcg merged commit 2b37433 into Tencent:master Aug 13, 2024
31 checks passed
wwwcg added a commit to wwwcg/Hippy that referenced this pull request Aug 13, 2024
@wwwcg
fix(ios): improve accuracy of ViewPager's onPageScroll params (Tencen…
2b94512 
…t#3992)

* fix(ios): accuracy of ViewPager's onPageScroll event parameters

* fix(ios): improve accuracy of ViewPager's onPageScroll parameters
wwwcg added a commit that referenced this pull request Aug 13, 2024
@wwwcg
fix(ios): improve accuracy of ViewPager's onPageScroll params (#3992)
6b8952a 
* fix(ios): accuracy of ViewPager's onPageScroll event parameters

* fix(ios): improve accuracy of ViewPager's onPageScroll parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruifanyuan ruifanyuan Awaiting requested review from ruifanyuan ruifanyuan is a code owner

Assignees
No one assigned
Labels
framework: ios size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wwwcg