Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): resolve floating point size comparison issues #3989

Merged
merged 2 commits into from
Aug 13, 2024
Merged

fix(ios): resolve floating point size comparison issues #3989

merged 2 commits into from
Aug 13, 2024

Conversation

wwwcg
Copy link
Collaborator

@wwwcg wwwcg commented Aug 7, 2024

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@wwwcg wwwcg requested a review from ruifanyuan as a code owner August 7, 2024 10:10
@github-actions github-actions bot added renderer: native size: m Denotes a PR that changes 100-499 lines labels Aug 7, 2024
@hippy-service Hippy Service
Copy link

hippy-service bot commented Aug 7, 2024

Hi, @wwwcg. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@wwwcg wwwcg force-pushed the refactor branch 2 times, most recently from 2c089f9 to f5a7750 Compare August 7, 2024 12:48
@wwwcg wwwcg merged commit 9eec723 into Tencent:main Aug 13, 2024
18 of 20 checks passed
@wwwcg wwwcg deleted the refactor branch August 13, 2024 13:31
wwwcg added a commit to wwwcg/Hippy that referenced this pull request Sep 13, 2024
@wwwcg
fix(ios): resolve floating point size comparison issues (Tencent#3989)
3d224ec
wwwcg added a commit that referenced this pull request Sep 13, 2024
@wwwcg
fix(ios): resolve floating point size comparison issues (#3989)
c911d56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruifanyuan ruifanyuan Awaiting requested review from ruifanyuan ruifanyuan is a code owner

Assignees
No one assigned
Labels
renderer: native size: m Denotes a PR that changes 100-499 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wwwcg