Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): check crash on config SetScaleFactor #3967

Merged
merged 1 commit into from
Jul 29, 2024
Merged

fix(core): check crash on config SetScaleFactor #3967

merged 1 commit into from
Jul 29, 2024
+4 −1

Conversation

etkmao
Copy link
Collaborator

@etkmao etkmao commented Jul 26, 2024

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@etkmao etkmao requested a review from siguangli July 26, 2024 13:27
@etkmao etkmao requested a review from ilikethese as a code owner July 26, 2024 13:27
@github-actions github-actions bot added dom: tree size: xs Denotes a PR that changes 0-9 lines labels Jul 26, 2024
@hippy-service Hippy Service
Copy link

hippy-service bot commented Jul 26, 2024

Hi, @etkmao. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@siguangli siguangli merged commit 74c1b7d into Tencent:main Jul 29, 2024
37 checks passed
siguangli pushed a commit to siguangli/Hippy that referenced this pull request Aug 8, 2024
@etkmao @siguangli2018
fix(core): check crash on config SetScaleFactor (Tencent#3967)
ac05bff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siguangli siguangli siguangli approved these changes

@ilikethese ilikethese Awaiting requested review from ilikethese ilikethese is a code owner

Assignees
No one assigned
Labels
dom: tree size: xs Denotes a PR that changes 0-9 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etkmao @siguangli