Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(action): install ninja-build before v8 build #3864

Merged
merged 5 commits into from
May 20, 2024

Conversation

zealotchen0
Copy link
Collaborator

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@github-actions github-actions bot added gh: workflow size: xs Denotes a PR that changes 0-9 lines labels May 20, 2024
Copy link

hippy-service bot commented May 20, 2024

Hi, @zealotchen0. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@zealotchen0 zealotchen0 merged commit 00cd292 into main May 20, 2024
19 of 20 checks passed
@zealotchen0 zealotchen0 deleted the feature/prebuild_v8 branch May 20, 2024 03:04
@zealotchen0 zealotchen0 restored the feature/prebuild_v8 branch May 23, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gh: workflow size: xs Denotes a PR that changes 0-9 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant