feat(dom): fix vue3 list item position #3826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zealotchen0
changed the title
github-actions
bot
added
driver: js
dom: tree
size: s
|
Hi, @zealotchen0. Thanks for your PR! 👏 🏷️ You can leave a comment in this PR with |
etkmao
approved these changes
Apr 12, 2024
|
Please check the following details: |
hippy-actions
bot
added
action(squash-merge): failed
|
🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.
|
zealotchen0
added a commit
to siguangli/Hippy
that referenced
this pull request
Apr 12, 2024
* feat(dom): fix vue3 list sort * feat(dom): fix vue3 list item position * feat(dom): perf code && adjust needSortByIndex * feat(dom): fix dom manager unit test * feat(dom): avoid get self depth when skip sortByIndex
wwwcg
pushed a commit
to wwwcg/Hippy
that referenced
this pull request
Apr 12, 2024
* feat(dom): fix vue3 list sort * feat(dom): fix vue3 list item position * feat(dom): perf code && adjust needSortByIndex * feat(dom): fix dom manager unit test * feat(dom): avoid get self depth when skip sortByIndex
wwwcg
pushed a commit
to wwwcg/Hippy
that referenced
this pull request
Apr 17, 2024
* feat(dom): fix vue3 list sort * feat(dom): fix vue3 list item position * feat(dom): perf code && adjust needSortByIndex * feat(dom): fix dom manager unit test * feat(dom): avoid get self depth when skip sortByIndex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a new pull request, please make sure: