Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ios): delete items in a range off screen in list component #3368

Merged
merged 1 commit into from
Jul 11, 2023
Merged

feat(ios): delete items in a range off screen in list component #3368

merged 1 commit into from
Jul 11, 2023

Conversation

ozonelmy
Copy link
Contributor

Pre-PR Checklist

  • I added/updated relevant documentation.
  • I followed the Convention Commit guideline with maximum 72 characters to submit commit message.
  • I squashed the repeated code commits.
  • I signed the [CLA].
  • I added/updated test cases to check the change I am making.
  • All existing and new tests are passing.

@ozonelmy ozonelmy requested a review from wwwcg as a code owner July 10, 2023 12:58
@github-actions github-actions bot added framework: ios size: m Denotes a PR that changes 100-499 lines labels Jul 10, 2023
@hippy-service
Copy link

hippy-service bot commented Jul 10, 2023

Hi, @ozonelmy. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

wwwcg
wwwcg reviewed Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@wwwcg wwwcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hippy-service
Copy link

hippy-service bot commented Jul 11, 2023

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Jul 11, 2023
@hippy-actions hippy-actions bot enabled auto-merge (rebase) July 11, 2023 02:26
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Jul 11, 2023
@hippy-actions hippy-actions bot merged commit 7f26aac into Tencent:master Jul 11, 2023
43 checks passed
@ozonelmy ozonelmy deleted the bugfix/long_list_component branch July 11, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wwwcg wwwcg wwwcg approved these changes

Assignees
No one assigned
Labels
framework: ios size: m Denotes a PR that changes 100-499 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ozonelmy @wwwcg