Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dom): measure textinput node #3361

Merged
merged 2 commits into from
Jul 7, 2023
Merged

feat(dom): measure textinput node #3361

merged 2 commits into from
Jul 7, 2023

Conversation

siguangli
Copy link
Collaborator

feat(android): measure textinput node

Pre-PR Checklist

  • I added/updated relevant documentation.
  • I followed the Convention Commit guideline with maximum 72 characters to submit commit message.
  • I squashed the repeated code commits.
  • I signed the [CLA].
  • I added/updated test cases to check the change I am making.
  • All existing and new tests are passing.

@ilikethese @siguangli2018
feat(dom): measure textinput node
a4f9da4 
feat(android): measure textinput node
@github-actions github-actions bot added renderer: native size: m Denotes a PR that changes 100-499 lines labels Jul 7, 2023
@hippy-service
Copy link

hippy-service bot commented Jul 7, 2023

Hi, @siguangli. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@hippy-service
Copy link

hippy-service bot commented Jul 7, 2023

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Jul 7, 2023
@hippy-actions hippy-actions bot enabled auto-merge (rebase) July 7, 2023 06:43
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Jul 7, 2023
@hippy-actions hippy-actions bot merged commit d3e3eac into Tencent:main Jul 7, 2023
19 checks passed
@siguangli siguangli deleted the fix/HippyTextInput branch July 7, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilikethese ilikethese ilikethese approved these changes

Assignees
No one assigned
Labels
renderer: native size: m Denotes a PR that changes 100-499 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siguangli @ilikethese @open-hippy