Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vue-next): fix element do not use beforeLoadStyle hooks issue #3339

Merged
merged 2 commits into from
Jul 14, 2023
Merged

fix(vue-next): fix element do not use beforeLoadStyle hooks issue #3339

merged 2 commits into from
Jul 14, 2023

Conversation

gguoyu
Copy link
Collaborator

@gguoyu gguoyu commented Jun 29, 2023

Pre-PR Checklist

  • I added/updated relevant documentation.
  • I followed the Convention Commit guideline with maximum 72 characters to submit commit message.
  • I squashed the repeated code commits.
  • I signed the [CLA].
  • I added/updated test cases to check the change I am making.
  • All existing and new tests are passing.

@gguoyu gguoyu requested a review from zealotchen0 as a code owner June 29, 2023 11:23
@github-actions github-actions bot added driver: js size: xs Denotes a PR that changes 0-9 lines labels Jun 29, 2023
@hippy-service
Copy link

hippy-service bot commented Jun 29, 2023

Hi, @gguoyu. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@hippy-service
Copy link

hippy-service bot commented Jun 29, 2023

After a quick scan, I have approved workflow to run.

🏷️ New commits in this PR would not be tested automatically until this pull request is reviewed by our collaborators.
🏷️ No need to worry about the status of merge_guard and [gh] pull request merge guard / merge_guard (pull_request_target) checks, once this pull request is met merge requirements, it will be automatically converted to successful status.

@hippy-service
Copy link

hippy-service bot commented Jul 14, 2023

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Jul 14, 2023
@hippy-actions hippy-actions bot enabled auto-merge (rebase) July 14, 2023 08:37
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Jul 14, 2023
auto-merge was automatically disabled July 14, 2023 08:43

Pull request was closed

@zealotchen0 zealotchen0 reopened this Jul 14, 2023
@zealotchen0 zealotchen0 added the action(squash-merge) Squash and merge action label Jul 14, 2023
@hippy-actions hippy-actions bot enabled auto-merge (squash) July 14, 2023 08:45
@hippy-actions hippy-actions bot removed the action(squash-merge) Squash and merge action label Jul 14, 2023
@zealotchen0 zealotchen0 merged commit 9c8dae8 into Tencent:master Jul 14, 2023
47 of 55 checks passed
zealotchen0 pushed a commit that referenced this pull request Aug 7, 2023
@gguoyu @open-hippy @zealotchen0
fix(vue-next): fix element do not use beforeLoadStyle hooks issue (#3339
2d63fa5 
)

Co-authored-by: OpenHippy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zealotchen0 zealotchen0 zealotchen0 approved these changes

Assignees
No one assigned
Labels
driver: js size: xs Denotes a PR that changes 0-9 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gguoyu @zealotchen0 @open-hippy